Hard to give a simple answer. There are pro’s and cons:
The drumming is more interesting in this band because rock music spanning 40 years covers a variety of styles (especially when we throw in some funk and blues tunes). I enjoy the music a bit more, we can play in more types of places, and the music tends to be very much more enjoyable to the average listener (for example, my wife has come to every single show this band has played. She came to about 1 out of every 3-4 metal shows, and didn’t really enjoy it very much).
In the metal band, we had a very loyal and consistent following of fans who absolutely LOVED us and were incredibly enthusiastic about our shows. The vibe also tended to be more interesting. A classic rock cover show is a very mundane experience. A metal show, on the other hand, is a step outside of the normal everyday happenings. It was more interesting whether for the love of the music, or the spectacle of it.
If I had to make a choice, though, I enjoy my current band much more. Already we’ve played 50 songs in the last two years and have 1,000s to choose from. Our next practice, in fact, we’ll be working on Personal Jesus from Depeche Mode, Gimme Shelter from The Rolling Stones, and a really cool mashup of School’s Out for Summer from Alice Cooper where we go into Another Brick in the Wall or the bridge…also working on Centerfold by Jay Giles band. Even thogh they all fit with what we are doing, I see them as four completely different genres.
With the metal band, we pretty much played the big four (Metallica, Megadeth, Slayer, and Anthrax) and Pantera, and then really had to scrape around to find songs that everyone in the fan base would know. The genre got very spread out after the mid 90s.
From the beginning, what I’m doing now was always the ultimate goal. My last two bands were, more or less, necessary steps to get here. We started off, as I think most new bands/musicians do, playing covers because the writing is already taken care of. We weren’t any good at it, but that’s what we did. I learned quickly, though, that there’s a minimum level of competency expected for cover bands that play out. That level is much lower if you want to play original music in music bars, so we shifted our focus to original music and rode that out for about a year. The metal band was a nice in between step. There’s certain niche bands you can play in with medium levels of proficiency (my friends have a punk cover band doing this right now. They play pop tunes punk rock style) and that’s kind of what the metal band was. Now I’m finally good enough to play in a standard house cover band.
BTW, I have to ask, are yoru kids still playing? How are they doing with their music?